Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 1213483003: Get rid of redundant parameter PositionIsOffsetInAnchor from PositionAlgorithm constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTextFormControlElement.cpp
diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp
index 714f5f96395b778a7c147e45813692d3ae1a0498..06c5c7b8f0214a0e4d2b61ed78ac7d5576670ad4 100644
--- a/Source/core/html/HTMLTextFormControlElement.cpp
+++ b/Source/core/html/HTMLTextFormControlElement.cpp
@@ -287,8 +287,8 @@ static Position positionForIndex(HTMLElement* innerEditor, int index)
if (index == 0) {
Node* node = NodeTraversal::next(*innerEditor, innerEditor);
if (node && node->isTextNode())
- return Position(node, 0, Position::PositionIsOffsetInAnchor);
- return Position(innerEditor, 0, Position::PositionIsOffsetInAnchor);
+ return Position(node, 0);
+ return Position(innerEditor, 0);
}
int remainingCharactersToMoveForward = index;
Node* lastBrOrText = innerEditor;
@@ -777,7 +777,7 @@ static Position innerNodePosition(const Position& innerPosition)
ASSERT(element);
RefPtrWillBeRawPtr<NodeList> childNodes = element->childNodes();
if (!childNodes->length())
- return Position(element, 0, Position::PositionIsOffsetInAnchor);
+ return Position(element, 0);
unsigned offset = 0;
@@ -940,7 +940,7 @@ static Position previousIfPositionIsAfterLineBreak(const Position& position, HTM
static inline Position startOfInnerText(const HTMLTextFormControlElement* textFormControl)
{
- return Position(textFormControl->innerEditorElement(), 0, Position::PositionIsOffsetInAnchor);
+ return Position(textFormControl->innerEditorElement(), 0);
}
Position HTMLTextFormControlElement::startOfSentence(const Position& position)
@@ -976,7 +976,7 @@ Position HTMLTextFormControlElement::startOfSentence(const Position& position)
static Position endOfInnerText(const HTMLTextFormControlElement* textFormControl)
{
HTMLElement* innerEditor = textFormControl->innerEditorElement();
- return Position(innerEditor, innerEditor->childNodes()->length(), Position::PositionIsOffsetInAnchor);
+ return Position(innerEditor, innerEditor->childNodes()->length());
}
Position HTMLTextFormControlElement::endOfSentence(const Position& position)
« no previous file with comments | « Source/core/editing/iterators/TextIteratorTest.cpp ('k') | Source/core/html/HTMLTextFormControlElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698