Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: Source/core/editing/VisibleSelectionTest.cpp

Issue 1213483003: Get rid of redundant parameter PositionIsOffsetInAnchor from PositionAlgorithm constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/TypingCommand.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleSelectionTest.cpp
diff --git a/Source/core/editing/VisibleSelectionTest.cpp b/Source/core/editing/VisibleSelectionTest.cpp
index 2282d6da596b227247c81e18e34fc5c164377da0..26daa76412e3b15b50c2ca2bdae1ea6df012f7fe 100644
--- a/Source/core/editing/VisibleSelectionTest.cpp
+++ b/Source/core/editing/VisibleSelectionTest.cpp
@@ -27,8 +27,8 @@ protected:
void setSelection(VisibleSelection& selection, int base, int extend)
{
Node* node = document().body()->firstChild();
- selection.setBase(Position(node, base, Position::PositionIsOffsetInAnchor));
- selection.setExtent(Position(node, extend, Position::PositionIsOffsetInAnchor));
+ selection.setBase(Position(node, base));
+ selection.setExtent(Position(node, extend));
}
static bool equalPositions(const Position&, const PositionInComposedTree&);
@@ -83,9 +83,9 @@ TEST_F(VisibleSelectionTest, ShadowCrossing)
VisibleSelection selection(Position::firstPositionInNode(one.get()), Position::lastPositionInNode(shadowRoot.get()));
EXPECT_EQ(Position(host.get(), Position::PositionIsBeforeAnchor), selection.start());
- EXPECT_EQ(Position(one->firstChild(), 0, Position::PositionIsOffsetInAnchor), selection.end());
- EXPECT_EQ(PositionInComposedTree(one->firstChild(), 0, PositionInComposedTree::PositionIsOffsetInAnchor), selection.startInComposedTree());
- EXPECT_EQ(PositionInComposedTree(six->firstChild(), 2, PositionInComposedTree::PositionIsOffsetInAnchor), selection.endInComposedTree());
+ EXPECT_EQ(Position(one->firstChild(), 0), selection.end());
+ EXPECT_EQ(PositionInComposedTree(one->firstChild(), 0), selection.startInComposedTree());
+ EXPECT_EQ(PositionInComposedTree(six->firstChild(), 2), selection.endInComposedTree());
}
TEST_F(VisibleSelectionTest, ShadowDistributedNodes)
@@ -102,10 +102,10 @@ TEST_F(VisibleSelectionTest, ShadowDistributedNodes)
VisibleSelection selection(Position::firstPositionInNode(one.get()), Position::lastPositionInNode(two.get()));
- EXPECT_EQ(Position(one->firstChild(), 0, Position::PositionIsOffsetInAnchor), selection.start());
- EXPECT_EQ(Position(two->firstChild(), 2, Position::PositionIsOffsetInAnchor), selection.end());
- EXPECT_EQ(PositionInComposedTree(five->firstChild(), 0, PositionInComposedTree::PositionIsOffsetInAnchor), selection.startInComposedTree());
- EXPECT_EQ(PositionInComposedTree(five->firstChild(), 2, PositionInComposedTree::PositionIsOffsetInAnchor), selection.endInComposedTree());
+ EXPECT_EQ(Position(one->firstChild(), 0), selection.start());
+ EXPECT_EQ(Position(two->firstChild(), 2), selection.end());
+ EXPECT_EQ(PositionInComposedTree(five->firstChild(), 0), selection.startInComposedTree());
+ EXPECT_EQ(PositionInComposedTree(five->firstChild(), 2), selection.endInComposedTree());
}
TEST_F(VisibleSelectionTest, ShadowNested)
@@ -125,9 +125,9 @@ TEST_F(VisibleSelectionTest, ShadowNested)
VisibleSelection selection(Position::firstPositionInNode(one.get()), Position::lastPositionInNode(shadowRoot2.get()));
EXPECT_EQ(Position(host.get(), Position::PositionIsBeforeAnchor), selection.start());
- EXPECT_EQ(Position(one->firstChild(), 0, Position::PositionIsOffsetInAnchor), selection.end());
- EXPECT_EQ(PositionInComposedTree(eight->firstChild(), 2, PositionInComposedTree::PositionIsOffsetInAnchor), selection.startInComposedTree());
- EXPECT_EQ(PositionInComposedTree(one->firstChild(), 0, PositionInComposedTree::PositionIsOffsetInAnchor), selection.endInComposedTree());
+ EXPECT_EQ(Position(one->firstChild(), 0), selection.end());
+ EXPECT_EQ(PositionInComposedTree(eight->firstChild(), 2), selection.startInComposedTree());
+ EXPECT_EQ(PositionInComposedTree(one->firstChild(), 0), selection.endInComposedTree());
}
TEST_F(VisibleSelectionTest, WordGranularity)
« no previous file with comments | « Source/core/editing/TypingCommand.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698