Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: Source/core/editing/ApplyStyleCommand.cpp

Issue 1213483003: Get rid of redundant parameter PositionIsOffsetInAnchor from PositionAlgorithm constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Position.cpp ('k') | Source/core/editing/EditingTestBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/ApplyStyleCommand.cpp
diff --git a/Source/core/editing/ApplyStyleCommand.cpp b/Source/core/editing/ApplyStyleCommand.cpp
index e9a151cf0ee1ba190d8f9c65209dbbb5a4c6d8be..65d2ddbe2514e1d2c627815c479772cb1da9d795 100644
--- a/Source/core/editing/ApplyStyleCommand.cpp
+++ b/Source/core/editing/ApplyStyleCommand.cpp
@@ -1320,8 +1320,8 @@ bool ApplyStyleCommand::mergeStartWithPreviousIfIdentical(const Position& start,
int startOffsetAdjustment = startChild->nodeIndex();
int endOffsetAdjustment = startNode == end.deprecatedNode() ? startOffsetAdjustment : 0;
- updateStartEnd(Position(startNode, startOffsetAdjustment, Position::PositionIsOffsetInAnchor),
- Position(end.deprecatedNode(), end.deprecatedEditingOffset() + endOffsetAdjustment, Position::PositionIsOffsetInAnchor));
+ updateStartEnd(Position(startNode, startOffsetAdjustment),
+ Position(end.deprecatedNode(), end.deprecatedEditingOffset() + endOffsetAdjustment));
return true;
}
@@ -1356,8 +1356,8 @@ bool ApplyStyleCommand::mergeEndWithNextIfIdentical(const Position& start, const
bool shouldUpdateStart = start.containerNode() == endNode;
int endOffset = nextChild ? nextChild->nodeIndex() : nextElement->childNodes()->length();
- updateStartEnd(shouldUpdateStart ? Position(nextElement, start.offsetInContainerNode(), Position::PositionIsOffsetInAnchor) : start,
- Position(nextElement, endOffset, Position::PositionIsOffsetInAnchor));
+ updateStartEnd(shouldUpdateStart ? Position(nextElement, start.offsetInContainerNode()) : start,
+ Position(nextElement, endOffset));
return true;
}
« no previous file with comments | « Source/core/dom/Position.cpp ('k') | Source/core/editing/EditingTestBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698