Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1213483003: Get rid of redundant parameter PositionIsOffsetInAnchor from PositionAlgorithm constructor (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, aboxhall, blink-reviews-style_chromium.org, mlamouri+watch-blink_chromium.org, sof, eae+blinkwatch, nektarios, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, dmazzoni, je_julie, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of redundant parameter PositionIsOffsetInAnchor from PositionAlgorithm constructor This patch gets rid of redundant parameter |PositionIsOffsetInAnchor| from three parameters version of |PositionAlgorithm<Strategy>| constructor, which takes anchor node, offset, and anchor type, to simplify call sites for improving code health, since position objects which anchor type are other than |PositionIsOffsetInAnchor| are constructed by two parameters version of constructor which takes anchor node and anchor type. BUGS=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -67 lines) Patch
M Source/core/dom/Position.h View 5 chunks +5 lines, -6 lines 0 comments Download
M Source/core/dom/Position.cpp View 7 chunks +11 lines, -22 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/EditingTestBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleSelectionTest.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
olipan bots failures are on layout test instead of compilation.
4 years, 10 months ago (2015-06-26 04:59:51 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-26 05:16:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213483003/1
4 years, 10 months ago (2015-06-26 05:16:30 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 05:34:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197891

Powered by Google App Engine
This is Rietveld 408576698