sky/sdk/lib/rendering/README.md - Issue 1213473003: Add asserts to catch potential misuses of the rendering framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/rendering/README.md

Issue 1213473003: Add asserts to catch potential misuses of the rendering framework. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/rendering/README.md

diff --git a/sky/sdk/lib/rendering/README.md b/sky/sdk/lib/rendering/README.md

index 3570d0ac9b6246450191cf44d935d2015e671682..3d6fc1dc13f7ed132fe9bc45911cc9df39d9ed2f 100644

--- a/sky/sdk/lib/rendering/README.md

+++ b/sky/sdk/lib/rendering/README.md

@@ -85,6 +85,13 @@ preinitialise the `parentData` member to set its values before you add

a node to its parent, you can preemptively call that future parent's

`setParentData()` method with the future child as the argument.

+TODO(ianh): Discuss putting per-child configuration information for

+the parent on the child's parentData.

+If you change a child's parentData dynamically, you must also call

+markNeedsLayout() on the parent, otherwise the new information will

+not take effect until something else triggers a layout.

### Box Model

#### Dimensions

« no previous file with comments | « sky/examples/rendering/sector_layout.dart ('k') | sky/sdk/lib/rendering/block.dart » ('j') | no next file with comments »