Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: sky/sdk/lib/rendering/block.dart

Issue 1213473003: Add asserts to catch potential misuses of the rendering framework. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/sdk/lib/rendering/README.md ('k') | sky/sdk/lib/rendering/box.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:math' as math; 5 import 'dart:math' as math;
6 6
7 import 'box.dart'; 7 import 'box.dart';
8 import 'object.dart'; 8 import 'object.dart';
9 9
10 class BlockParentData extends BoxParentData with ContainerParentDataMixin<Render Box> { } 10 class BlockParentData extends BoxParentData with ContainerParentDataMixin<Render Box> { }
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 return _getIntrinsicHeight(constraints); 77 return _getIntrinsicHeight(constraints);
78 } 78 }
79 79
80 double getDistanceToActualBaseline(TextBaseline baseline) { 80 double getDistanceToActualBaseline(TextBaseline baseline) {
81 return defaultGetDistanceToFirstActualBaseline(baseline); 81 return defaultGetDistanceToFirstActualBaseline(baseline);
82 } 82 }
83 83
84 void performLayout() { 84 void performLayout() {
85 assert(constraints is BoxConstraints); 85 assert(constraints is BoxConstraints);
86 double width = constraints.constrainWidth(constraints.maxWidth); 86 double width = constraints.constrainWidth(constraints.maxWidth);
87 bool usesChildSize = !constraints.hasTightHeight;
88 BoxConstraints innerConstraints = _getInnerConstraintsForWidth(width); 87 BoxConstraints innerConstraints = _getInnerConstraintsForWidth(width);
89 double y = 0.0; 88 double y = 0.0;
90 RenderBox child = firstChild; 89 RenderBox child = firstChild;
91 while (child != null) { 90 while (child != null) {
92 child.layout(innerConstraints, parentUsesSize: usesChildSize); 91 child.layout(innerConstraints, parentUsesSize: true);
93 assert(child.parentData is BlockParentData); 92 assert(child.parentData is BlockParentData);
94 child.parentData.position = new Point(0.0, y); 93 child.parentData.position = new Point(0.0, y);
95 y += child.size.height; 94 y += child.size.height;
96 child = child.parentData.nextSibling; 95 child = child.parentData.nextSibling;
97 } 96 }
98 size = new Size(width, constraints.constrainHeight(y)); 97 size = new Size(width, constraints.constrainHeight(y));
99 assert(size.width < double.INFINITY); 98 assert(size.width < double.INFINITY);
100 assert(size.height < double.INFINITY); 99 assert(size.height < double.INFINITY);
101 } 100 }
102 101
103 void hitTestChildren(HitTestResult result, { Point position }) { 102 void hitTestChildren(HitTestResult result, { Point position }) {
104 defaultHitTestChildren(result, position: position); 103 defaultHitTestChildren(result, position: position);
105 } 104 }
106 105
107 void paint(RenderCanvas canvas) { 106 void paint(RenderCanvas canvas) {
108 defaultPaint(canvas); 107 defaultPaint(canvas);
109 } 108 }
110 109
111 } 110 }
112 111
OLDNEW
« no previous file with comments | « sky/sdk/lib/rendering/README.md ('k') | sky/sdk/lib/rendering/box.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698