Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1213433007: Add -bootclasspath argument to javac. (Closed)

Created:
5 years, 5 months ago by Fredrik Öhrn
Modified:
5 years, 5 months ago
Reviewers:
cjhopman, Dirk Pranke
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add -bootclasspath argument to javac. This silences the warning "bootstrap class path not set in conjunction with -source 1.7" when building with OpenJDK 1.8. The multiple_proguards test was removed as javac will now catch the use of host packages that do not exist on Android. BUG= Committed: https://crrev.com/718538ef3a6e6f7104101ef37502052c88c5641c Cr-Commit-Position: refs/heads/master@{#337805}

Patch Set 1 #

Patch Set 2 : Rebase path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -112 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/gyp/javac.py View 6 chunks +17 lines, -2 lines 0 comments Download
D build/android/tests/multiple_proguards/AndroidManifest.xml View 1 chunk +0 lines, -30 lines 0 comments Download
D build/android/tests/multiple_proguards/multiple_proguards.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D build/android/tests/multiple_proguards/proguard1.flags View 1 chunk +0 lines, -1 line 0 comments Download
D build/android/tests/multiple_proguards/proguard2.flags View 1 chunk +0 lines, -1 line 0 comments Download
D build/android/tests/multiple_proguards/src/dummy/DummyActivity.java View 1 chunk +0 lines, -26 lines 0 comments Download
D build/android/tests/multiple_proguards/src/dummy/NativeLibraries.java View 1 chunk +0 lines, -17 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/java.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Fredrik Öhrn
+cjhopman looks like you review these files a lot +dpranke for the .gni file
5 years, 5 months ago (2015-07-03 13:22:58 UTC) #2
Dirk Pranke
internal_rules.gni lgtm.
5 years, 5 months ago (2015-07-03 19:24:50 UTC) #3
Fredrik Öhrn
On 2015/07/03 19:24:50, Dirk Pranke wrote: > internal_rules.gni lgtm. 'cept I forgot to rebase the ...
5 years, 5 months ago (2015-07-07 15:03:39 UTC) #4
cjhopman
lgtm
5 years, 5 months ago (2015-07-07 18:42:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213433007/20001
5 years, 5 months ago (2015-07-08 08:27:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/41962)
5 years, 5 months ago (2015-07-08 10:57:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213433007/20001
5 years, 5 months ago (2015-07-08 13:05:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 13:09:14 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 13:10:19 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/718538ef3a6e6f7104101ef37502052c88c5641c
Cr-Commit-Position: refs/heads/master@{#337805}

Powered by Google App Engine
This is Rietveld 408576698