tools/telemetry/telemetry/internal/forwarders/android_forwarder.py - Issue 1213423003: Remove adb_commands from android_browser_backend and android_browser_backend_settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/forwarders/android_forwarder.py

Issue 1213423003: Remove adb_commands from android_browser_backend and android_browser_backend_settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo referencing invalid _backend_settings member of WebviewShellBackendSettings Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/internal/forwarders/android_forwarder.py

diff --git a/tools/telemetry/telemetry/internal/forwarders/android_forwarder.py b/tools/telemetry/telemetry/internal/forwarders/android_forwarder.py

index daaac402e61cc8a6f025a7895fdd7c0fd4afa3d5..11e3a602953c9a673cc1354f2498fb4925c046f9 100644

--- a/tools/telemetry/telemetry/internal/forwarders/android_forwarder.py

+++ b/tools/telemetry/telemetry/internal/forwarders/android_forwarder.py

@@ -29,9 +29,7 @@ class AndroidForwarderFactory(forwarders.ForwarderFactory):

def __init__(self, device, use_rndis):

super(AndroidForwarderFactory, self).__init__()

- # TODO(sullivan): remove this line in

- # https://codereview.chromium.org/1213423003/

- self._device = device.device()

+ self._device = device

self._rndis_configurator = None

if use_rndis:

self._rndis_configurator = AndroidRndisConfigurator(self._device)

« no previous file with comments | « tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py ('k') | no next file » | no next file with comments »