Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py

Issue 1213423003: Remove adb_commands from android_browser_backend and android_browser_backend_settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo referencing invalid _backend_settings member of WebviewShellBackendSettings Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
diff --git a/tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py b/tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
index 21f4f1db44f8d5016fb1f777d25431f76bc92424..356761f1f1fb644c257ecbf7d8964f7ad41c9623 100644
--- a/tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
+++ b/tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
@@ -37,7 +37,7 @@ class AndroidBrowserBackendSettings(object):
def GetCommandLineFile(self, is_user_debug_build): # pylint: disable=W0613
return self._cmdline_file
- def GetDevtoolsRemotePort(self, adb):
+ def GetDevtoolsRemotePort(self, device):
raise NotImplementedError()
@property
@@ -64,7 +64,7 @@ class ChromeBackendSettings(AndroidBrowserBackendSettings):
pseudo_exec_name='chrome',
supports_tab_control=True)
- def GetDevtoolsRemotePort(self, adb):
+ def GetDevtoolsRemotePort(self, device):
return 'localabstract:chrome_devtools_remote'
@@ -77,7 +77,7 @@ class ContentShellBackendSettings(AndroidBrowserBackendSettings):
pseudo_exec_name='content_shell',
supports_tab_control=False)
- def GetDevtoolsRemotePort(self, adb):
+ def GetDevtoolsRemotePort(self, device):
return 'localabstract:content_shell_devtools_remote'
@@ -90,7 +90,7 @@ class ChromeShellBackendSettings(AndroidBrowserBackendSettings):
pseudo_exec_name='chrome_shell',
supports_tab_control=False)
- def GetDevtoolsRemotePort(self, adb):
+ def GetDevtoolsRemotePort(self, device):
return 'localabstract:chrome_shell_devtools_remote'
@@ -106,26 +106,26 @@ class WebviewBackendSettings(AndroidBrowserBackendSettings):
pseudo_exec_name='webview',
supports_tab_control=False)
- def GetDevtoolsRemotePort(self, adb):
+ def GetDevtoolsRemotePort(self, device):
# The DevTools socket name for WebView depends on the activity PID's.
retries = 0
timeout = 1
pid = None
while True:
- pids = adb.ExtractPid(self.package)
- if len(pids) > 0:
- pid = pids[-1]
- break
- time.sleep(timeout)
- retries += 1
- timeout *= 2
- if retries == 4:
- logging.critical('android_browser_backend: Timeout while waiting for '
- 'activity %s:%s to come up',
- self.package,
- self.activity)
- raise exceptions.BrowserGoneException(self.browser,
- 'Timeout waiting for PID.')
+ pids = device.GetPids(self.package)
+ if not pids or self.package not in pids:
+ time.sleep(timeout)
+ retries += 1
+ timeout *= 2
+ if retries == 4:
+ logging.critical('android_browser_backend: Timeout while waiting for '
+ 'activity %s:%s to come up',
+ self.package,
+ self.activity)
+ raise exceptions.BrowserGoneException(self.browser,
+ 'Timeout waiting for PID.')
+ pid = pids[self.package]
+ break
return 'localabstract:webview_devtools_remote_%s' % str(pid)

Powered by Google App Engine
This is Rietveld 408576698