Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213383005: Rework GrPipelineInfo (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : more #

Patch Set 4 : more #

Patch Set 5 : more #

Total comments: 2

Patch Set 6 : more #

Patch Set 7 : rebase #

Patch Set 8 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -190 lines) Patch
M include/gpu/GrXferProcessor.h View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 chunks +13 lines, -16 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 11 chunks +23 lines, -21 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 5 chunks +25 lines, -30 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 2 3 4 5 6 7 3 chunks +25 lines, -8 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 2 3 4 1 chunk +58 lines, -9 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 3 4 5 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
bsalomon
I want to follow on with some improvements and consolidation to batch tracking within the ...
5 years, 5 months ago (2015-07-06 22:27:59 UTC) #2
bsalomon
https://codereview.chromium.org/1213383005/diff/80001/src/gpu/GrPrimitiveProcessor.h File src/gpu/GrPrimitiveProcessor.h (right): https://codereview.chromium.org/1213383005/diff/80001/src/gpu/GrPrimitiveProcessor.h#newcode101 src/gpu/GrPrimitiveProcessor.h:101: SkASSERT(SkToBool(kReadsColor_GrPipelineInfoFlag & fFlags)); On 2015/07/06 22:27:58, bsalomon wrote: > ...
5 years, 5 months ago (2015-07-06 22:37:39 UTC) #3
joshualitt
On 2015/07/06 22:37:39, bsalomon wrote: > https://codereview.chromium.org/1213383005/diff/80001/src/gpu/GrPrimitiveProcessor.h > File src/gpu/GrPrimitiveProcessor.h (right): > > https://codereview.chromium.org/1213383005/diff/80001/src/gpu/GrPrimitiveProcessor.h#newcode101 > ...
5 years, 5 months ago (2015-07-07 13:46:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213383005/120001
5 years, 5 months ago (2015-07-08 14:48:40 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/f5179a4c490bc787190321bd8ffdb0e6a4efa9ac
5 years, 5 months ago (2015-07-08 14:56:03 UTC) #8
bsalomon
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1213013003/ by bsalomon@google.com. ...
5 years, 5 months ago (2015-07-08 17:20:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213383005/60002
5 years, 5 months ago (2015-07-08 18:00:35 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 18:26:42 UTC) #13
Message was sent while issue was closed. 
Committed patchset #8 (id:60002) as
https://skia.googlesource.com/skia/+/7765a477ee3ca5e2c6ada1e16c31dfaae2079240

Powered by Google App Engine
This is Rietveld 408576698