Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1213383003: PPC: Fix InstanceOfStub's inlined call site logic. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix InstanceOfStub's inlined call site logic. This change makes the patching logic less prone to errors in the face of variable instruction mov sequences. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/549749d374f0c6ba1a4f3251e0b71aa6fd4bf68b Cr-Commit-Position: refs/heads/master@{#29416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
M src/ppc/code-stubs-ppc.cc View 4 chunks +12 lines, -15 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 4 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-06-30 21:42:59 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-07-01 12:56:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213383003/1
5 years, 5 months ago (2015-07-01 13:07:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 13:35:03 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 13:35:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/549749d374f0c6ba1a4f3251e0b71aa6fd4bf68b
Cr-Commit-Position: refs/heads/master@{#29416}

Powered by Google App Engine
This is Rietveld 408576698