Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gcl.py

Issue 1213363002: Don't upload correct project name anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Remove unnecessary comment. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 16f4f282735f2f32792775963c1ad88894ee53c1..bbc44322bf5a51c4e8d6532c381f4ea190c6fe6e 100755
--- a/gcl.py
+++ b/gcl.py
@@ -47,6 +47,9 @@ CODEREVIEW_SETTINGS = {
# we store information about changelists.
REPOSITORY_ROOT = ""
+# Replacement for project name.
+SWITCH_TO_GIT = "SWITCH_TO_GIT_ALREADY"
+
# Filename where we store repository specific information for gcl.
CODEREVIEW_SETTINGS_FILE = "codereview.settings"
CODEREVIEW_SETTINGS_FILE_NOT_FOUND = (
@@ -879,6 +882,10 @@ def CMDupload(change_info, args):
# Uploading a new patchset.
upload_arg.append("--issue=%d" % change_info.issue)
+ project = GetCodeReviewSetting("PROJECT")
+ if project:
+ upload_arg.append("--project=%s" % SWITCH_TO_GIT)
+
if not any(i.startswith('--title') or i.startswith('-t') for i in args):
upload_arg.append('--title= ')
else:
@@ -919,7 +926,7 @@ def CMDupload(change_info, args):
project = GetCodeReviewSetting("PROJECT")
if project:
- upload_arg.append("--project=%s" % project)
+ upload_arg.append("--project=%s" % SWITCH_TO_GIT)
# If we have a lot of files with long paths, then we won't be able to fit
# the command to "svn diff". Instead, we generate the diff manually for
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698