Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213353003: More fixes for position:fixed with root layer scrolling. (Closed)

Created:
5 years, 5 months ago by skobes
Modified:
5 years, 5 months ago
Reviewers:
dsinclair
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-reviews-rendering, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, szager1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

More fixes for position:fixed with root layer scrolling. Exclude scrollbars from container's available space for positioning, and apply the root layer's overflow clip for hit testing. BUG=417782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198218

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Patch
A LayoutTests/fast/scrolling/fixed-position-behind-scrollbar.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/scrolling/fixed-position-behind-scrollbar-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
skobes
5 years, 5 months ago (2015-06-30 22:53:55 UTC) #4
dsinclair
lgtm
5 years, 5 months ago (2015-07-02 13:52:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213353003/40001
5 years, 5 months ago (2015-07-02 13:52:56 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 14:58:03 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198218

Powered by Google App Engine
This is Rietveld 408576698