Build public cast_shell on x86 with GN.

chromecast/renderer/BUILD.gn

Index: chromecast/renderer/BUILD.gn
diff --git a/chromecast/renderer/BUILD.gn b/chromecast/renderer/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..8dd04511690f5f90f3b09f59fc01e575b8f982ab
--- /dev/null
+++ b/chromecast/renderer/BUILD.gn
@@ -0,0 +1,72 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//chromecast/chromecast.gni")
+
+source_set("renderer") {
+  sources = [
+    "cast_content_renderer_client.cc",
+    "cast_content_renderer_client.h",
+    "cast_media_load_deferrer.cc",
+    "cast_media_load_deferrer.h",
+    "cast_render_process_observer.cc",
+    "cast_render_process_observer.h",
+    "key_systems_cast.cc",
+    "key_systems_cast.h",
+
+    # TODO(slan): Can these be added into ":media"?
+    "media/capabilities_message_filter.cc",
+    "media/capabilities_message_filter.h",
+  ]
+
+  if (!is_chromecast_chrome_branded) {
+    sources += [ "cast_content_renderer_client_simple.cc" ]
+  }
+
+  public_deps = [
+    ":media",
+  ]
+
+  deps = [
+    "//base",
+    "//chromecast/base",
+    "//chromecast/crash",
+    "//chromecast/common:media",
+    "//chromecast/media",
+    "//components/cdm/renderer",
+    "//components/network_hints/renderer",
+    "//content/public/common",
+    "//content/public/renderer",
+    "//crypto",
+    "//ipc",
+    "//media",
+    "//third_party/widevine/cdm:version_h",
+  ]
+}
+
+source_set("media") {

[mbjorge, 2015/08/04 18:10:54]

Maybe put this in chromecast/renderer/media/BUILD.gn ?

[slan, 2015/08/04 21:22:05]

This was my initial thought. It is really a style choice. IMO, it is not
sufficiently complex to merit its own target. I think we should keep it here for
now, but I will add a TODO if we find that it makes more sense to move it down.
Perhaps if we add unit testing, for example.

[mbjorge, 2015/08/04 22:09:14]

I feel like complexity isn't a good metric to base targets on.
Chromium has lots of targets that are very simple, e.g.:
https://code.google.com/p/chromium/codesearch#chromium/src/device/core/BUILD.gn
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/ipc/BUILD.gn
https://code.google.com/p/chromium/codesearch#chromium/src/mojo/util/BUILD.gn

The SG only says: "It usually makes sense to have more build files closer to the
code than fewer ones at the toplevel (this is in contrast with what we did with
GYP). This makes things easier to find and owners reviews easier since changes
are more focused." So there doesn't seem to be a firm ruling.

However, I think (as you mentioned in your other comment), that if the target
doesn't stand alone, then it's reasonable to keep it here (or in general, keep
it with its parent).

Still, my vote would be to put it in media/BUILD.gn, since it's arbitrary and I
personally prefer having smaller targets very close to the corresponding source
files. 

But it's really a minor detail, and I think, grand scheme, it's fine to leave it
as is and add a TODO as you said (and perhaps do the same for browser:media and
common:media?)

[slan, 2015/08/04 23:55:48]

Thanks for the in-depth comment here. I think that moving the targets into
*/media is a good choice for the reasons you mentioned. After some thought,
there is little sense in putting TODOs in here which might never be addressed
and which clutter the code.

+  sources = [
+    "media/audio_pipeline_proxy.cc",
+    "media/audio_pipeline_proxy.h",
+    "media/chromecast_media_renderer_factory.cc",
+    "media/chromecast_media_renderer_factory.h",
+    "media/cma_message_filter_proxy.cc",
+    "media/cma_message_filter_proxy.h",
+    "media/media_channel_proxy.cc",
+    "media/media_channel_proxy.h",
+    "media/media_pipeline_proxy.cc",
+    "media/media_pipeline_proxy.h",
+    "media/video_pipeline_proxy.cc",
+    "media/video_pipeline_proxy.h",
+  ]
+
+  deps = [
+    "//base",
+    "//chromecast/common:media",
+    "//chromecast/media",
+    "//content/public/renderer",
+    "//ipc",
+    "//media",
+  ]
+}