Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chromecast/build/args.gn

Issue 1213333003: Build public cast_shell on x86 with GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Remove hack regarding Pepper plugins. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/build/args.gn
diff --git a/chromecast/build/args.gn b/chromecast/build/args.gn
index 1624b0a9a6b0eb17df4de7d886312dfea369939b..b8a668042e4bbfaf47909aab6f50bf10f8c82004 100644
--- a/chromecast/build/args.gn
+++ b/chromecast/build/args.gn
@@ -3,11 +3,41 @@
root_extra_deps = [ "//chromecast" ]
-# Flags set from build/common.gypi
+# See //build/config/features.gni for information on this variable.
+# When this is enabled, the ENABLE_BROWSER_CDMS macro gets defined, which
+# in turn builds //content/browser/render_host/render_process_host_impl.h's
+# GetBrowserCdm().
+enable_browser_cdms = true
+
+# TODO(slan): Add note about this variable.
mbjorge 2015/08/04 18:10:54 What needs to be noted about this variable? Is it
slan 2015/08/04 21:22:05 Comment added. These are just to provide develop
enable_mpeg2ts_stream_parser = true
+
+# See //build/common.gypi and note that this gets set to "ChromeOS" when
+# chromecast==1. If you omit this, ffmpeg_branding defaults to "Chromium", only
+# registering a subset of required codecs in
+# //src/third_party/ffmpeg/libavcodec/allcodecs.c.
+# Instead of maintaining a separate "Chromecast" ffmpeg branding, "ChromeOS" is
+# used, as it sufficiently covers all the required codecs.
ffmpeg_branding = "ChromeOS"
+
+# Setting this to true generates libeglplatform_shim.so.1 from
+# //ui/ozone/platform/egltest:egl_platform_x11, which is loaded in
+# OzonePlatformEgltest::LoadShim().
+ozone_platform_ozonex = true
+
+# See the corresponding TODO(gyp) comment in //build/config/features.gni.
+# Setting this to true defines the USE_PROPRIETARY_CODECS macro and the proper
+# EME_CODEC macros in //media/base/eme_constants.h.
proprietary_codecs = true
-enable_browser_cdms = true
+
+# See //build/config/ui.gni. Notice that use_x11 = is_linux && !use_ozone.
+# Without setting use_ozone to true, this make use_x11 = true and the
+# USE_X11 macro to be defined. This in turn causes us to go down the wrong
+# code path in //ui/base/ime/input_method_factory.cc:CreateInputMethod().
+# "return make_scoped_ptr(new InputMethodAuraLinux(delegate));"
+# instead of
+# "return make_scoped_ptr(new InputMethodMinimal(delegate));"
+use_ozone = true
# TODO(halliwell): look into supporting Cast Ozone with GN.
# ozone_platform_cast = 1
# TODO(gyp): Add support for blink_logging_always_on and enable it.

Powered by Google App Engine
This is Rietveld 408576698