Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7149)

Unified Diff: chromecast/app/BUILD.gn

Issue 1213333003: Build public cast_shell on x86 with GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Modifies gn args to make cast_shell run! Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/app/BUILD.gn
diff --git a/chromecast/app/BUILD.gn b/chromecast/app/BUILD.gn
index 51cf158402f168984fb9b9dd5c435d9d6cde738d..856919191f541b40a661988390bdac9780390fdf 100644
--- a/chromecast/app/BUILD.gn
+++ b/chromecast/app/BUILD.gn
@@ -3,6 +3,28 @@
# found in the LICENSE file.
import("//testing/test.gni")
+import("//tools/grit/grit_rule.gni")
+
+source_set("main_delegate") {
gunsch 2015/08/04 00:43:10 Should this simply be the "app" source_set, and in
slan 2015/08/04 21:22:04 Done.
+ sources = [
+ "cast_main_delegate.cc",
+ "cast_main_delegate.h",
+ ]
+
+ deps = [
+ ":cast_crash_client",
+ "//base",
+ "//chromecast/base",
+ "//chromecast/browser",
+ "//chromecast/common",
+ "//chromecast/renderer",
+ "//components/crash/app:lib",
+ "//content/public/app:both",
+ "//content/public/browser",
+ "//content/public/common",
+ "//ui/base",
+ ]
+}
source_set("cast_crash_client") {
sources = [
@@ -39,3 +61,80 @@ test("cast_shell_unittests") {
"//testing/gtest",
]
}
+
+grit("resources") {
+ source = "//chromecast/app/resources/shell_resources.grd"
+
+ resource_ids = "//chromecast/app/resources/resource_ids"
+
+ outputs = [
+ "grit/shell_resources.h",
+ "shell_resources.pak",
+ "shell_resources.rc",
+ ]
+}
+
+grit("chromecast_settings") {
+ source = "//chromecast/app/resources/chromecast_settings.grd"
+
+ resource_ids = "//chromecast/app/resources/resource_ids"
+
+ outputs = [
+ # TODO(slan): These outputs should be required. Why is this building...?
gunsch 2015/08/04 00:43:10 These are "required" but nothing enforces them at
slan 2015/08/04 21:22:04 Please see the documentation here: https://code.g
+ #"grit/chromecast_settings.h",
+ #"chromecast_settings_am.pak",
+ #"chromecast_settings_ar.pak",
+ #"chromecast_settings_bg.pak",
+ #"chromecast_settings_bn.pak",
+ #"chromecast_settings_ca.pak",
+ #"chromecast_settings_cs.pak",
+ #"chromecast_settings_da.pak",
+ #"chromecast_settings_de.pak",
+ #"chromecast_settings_el.pak",
+ #"chromecast_settings_en-GB.pak",
+ #"chromecast_settings_en-US.pak",
+ #"chromecast_settings_es.pak",
+ #"chromecast_settings_es-419.pak",
+ #"chromecast_settings_et.pak",
+ #"chromecast_settings_fa.pak",
+ #"chromecast_settings_fake-bidi.pak",
+ #"chromecast_settings_fi.pak",
+ #"chromecast_settings_fil.pak",
+ #"chromecast_settings_fr.pak",
+ #"chromecast_settings_gu.pak",
+ #"chromecast_settings_he.pak",
+ #"chromecast_settings_hi.pak",
+ #"chromecast_settings_hr.pak",
+ #"chromecast_settings_hu.pak",
+ #"chromecast_settings_id.pak",
+ #"chromecast_settings_it.pak",
+ #"chromecast_settings_ja.pak",
+ #"chromecast_settings_kn.pak",
+ #"chromecast_settings_ko.pak",
+ #"chromecast_settings_lt.pak",
+ #"chromecast_settings_lv.pak",
+ #"chromecast_settings_ml.pak",
+ #"chromecast_settings_mr.pak",
+ #"chromecast_settings_ms.pak",
+ #"chromecast_settings_nl.pak",
+ #"chromecast_settings_nb.pak",
+ #"chromecast_settings_pl.pak",
+ #"chromecast_settings_pt-BR.pak",
+ #"chromecast_settings_pt-PT.pak",
+ #"chromecast_settings_ro.pak",
+ #"chromecast_settings_ru.pak",
+ #"chromecast_settings_sk.pak",
+ #"chromecast_settings_sl.pak",
+ #"chromecast_settings_sr.pak",
+ #"chromecast_settings_sv.pak",
+ #"chromecast_settings_sw.pak",
+ #"chromecast_settings_ta.pak",
+ #"chromecast_settings_te.pak",
+ #"chromecast_settings_th.pak",
+ #"chromecast_settings_tr.pak",
+ #"chromecast_settings_uk.pak",
+ #"chromecast_settings_vi.pak",
+ #"chromecast_settings_zh-CN.pak",
+ #"chromecast_settings_zh-TW.pak",
+ ]
+}
« no previous file with comments | « chromecast/BUILD.gn ('k') | chromecast/browser/BUILD.gn » ('j') | chromecast/browser/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698