Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: remoting/codec/video_encoder_vpx_unittest.cc

Issue 1213323003: Supply empty frames until codec is done with top-off. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Loosen top-off frame count tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/codec/video_encoder_vpx.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/codec/video_encoder_vpx_unittest.cc
diff --git a/remoting/codec/video_encoder_vpx_unittest.cc b/remoting/codec/video_encoder_vpx_unittest.cc
index efe07d2b5e296c77c0a86919f315f5a64640f608..dfb3627d9c0df5f60dc543f869cc384c7265799e 100644
--- a/remoting/codec/video_encoder_vpx_unittest.cc
+++ b/remoting/codec/video_encoder_vpx_unittest.cc
@@ -162,21 +162,23 @@ TEST(VideoEncoderVpxTest, DpiPropagation) {
EXPECT_EQ(packet->format().y_dpi(), 97);
}
-TEST(VideoEncoderVerbatimTest, Vp8EncodeUnchangedFrame) {
+TEST(VideoEncoderVpxTest, Vp8EncodeUnchangedFrame) {
scoped_ptr<VideoEncoderVpx> encoder(VideoEncoderVpx::CreateForVP8());
TestVideoEncoderEmptyFrames(encoder.get(), 0);
}
-TEST(VideoEncoderVerbatimTest, Vp9LosslessUnchangedFrame) {
+TEST(VideoEncoderVpxTest, Vp9LosslessUnchangedFrame) {
scoped_ptr<VideoEncoderVpx> encoder(VideoEncoderVpx::CreateForVP9());
encoder->SetLosslessEncode(true);
TestVideoEncoderEmptyFrames(encoder.get(), 0);
}
-TEST(VideoEncoderVerbatimTest, Vp9LossyUnchangedFrame) {
+TEST(VideoEncoderVpxTest, Vp9LossyUnchangedFrame) {
scoped_ptr<VideoEncoderVpx> encoder(VideoEncoderVpx::CreateForVP9());
encoder->SetLosslessEncode(false);
- TestVideoEncoderEmptyFrames(encoder.get(), 2);
+ // Expect that VP9+CR should generate no more than 10 top-off frames
+ // per cycle, and take no more than 2 cycles to top-off.
+ TestVideoEncoderEmptyFrames(encoder.get(), 20);
}
} // namespace remoting
« no previous file with comments | « remoting/codec/video_encoder_vpx.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698