Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1213323003: Supply empty frames until codec is done with top-off. (Closed)

Created:
5 years, 5 months ago by Wez
Modified:
5 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org, aconverse
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supply empty frames until codec is done with top-off. Previously the VideoEncoderVpx would pass up to two empty/unchanged frames to the codec when in lossy-VP9 mode, to allow some quality top-off even if the desktop is otherwise idle. VideoEncoderVpx now calls the codec until it reports that no changes were encoded. This CL also uses a DesktopSize to hold the active-map dimensions. BUG=134202 Committed: https://crrev.com/9242f6c195c4b6ed37c1e565362f8324f9edc879 Cr-Commit-Position: refs/heads/master@{#338371}

Patch Set 1 #

Patch Set 2 : Fix test names #

Total comments: 2

Patch Set 3 : Loosen top-off frame count tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -45 lines) Patch
M remoting/codec/codec_test.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/codec/codec_test.cc View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M remoting/codec/video_encoder_vpx.h View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/codec/video_encoder_vpx.cc View 8 chunks +25 lines, -30 lines 0 comments Download
M remoting/codec/video_encoder_vpx_unittest.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Wez
PTAL
5 years, 5 months ago (2015-07-02 16:57:28 UTC) #2
Sergey Ulanov
lgtm https://codereview.chromium.org/1213323003/diff/20001/remoting/codec/video_encoder_vpx.h File remoting/codec/video_encoder_vpx.h (right): https://codereview.chromium.org/1213323003/diff/20001/remoting/codec/video_encoder_vpx.h#newcode79 remoting/codec/video_encoder_vpx.h:79: bool encode_unchanged_frame_; = false; and remove initializer in ...
5 years, 5 months ago (2015-07-06 17:58:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213323003/20001
5 years, 5 months ago (2015-07-08 23:48:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/83849) (exceeded global retry quota)
5 years, 5 months ago (2015-07-09 00:24:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213323003/40001
5 years, 5 months ago (2015-07-10 21:07:39 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-10 21:43:39 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:46:04 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9242f6c195c4b6ed37c1e565362f8324f9edc879
Cr-Commit-Position: refs/heads/master@{#338371}

Powered by Google App Engine
This is Rietveld 408576698