Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1213313004: Start incremental marking in long idle notification for background tab (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Start incremental marking in long idle notification for background tab disregarding the allocation throughput. BUG=chromium:506132 LOG=NO Committed: https://crrev.com/fe8c8c3bc5bdd68e9d57a661f9ac825bdecd5b2b Cr-Commit-Position: refs/heads/master@{#29515}

Patch Set 1 #

Patch Set 2 : Rework #

Patch Set 3 : Add tests #

Total comments: 3

Patch Set 4 : Extract into separate function #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -12 lines) Patch
M src/heap/heap.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download
M src/heap/memory-reducer.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M src/heap/memory-reducer.cc View 1 2 chunks +47 lines, -11 lines 0 comments Download
M test/unittests/heap/memory-reducer-unittest.cc View 1 2 4 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ulan
PTAL
5 years, 5 months ago (2015-07-02 14:03:24 UTC) #2
ulan
I uploaded new patch-test with new event kBackgroundIdleNotification https://codereview.chromium.org/1213313004/diff/40001/src/heap/memory-reducer.cc File src/heap/memory-reducer.cc (right): https://codereview.chromium.org/1213313004/diff/40001/src/heap/memory-reducer.cc#newcode120 src/heap/memory-reducer.cc:120: switch ...
5 years, 5 months ago (2015-07-06 08:38:44 UTC) #3
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1213313004/diff/40001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1213313004/diff/40001/src/heap/heap.cc#newcode4986 src/heap/heap.cc:4986: } Let's make this block a method to ...
5 years, 5 months ago (2015-07-07 07:49:34 UTC) #4
ulan
Thanks https://codereview.chromium.org/1213313004/diff/40001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1213313004/diff/40001/src/heap/heap.cc#newcode4986 src/heap/heap.cc:4986: } On 2015/07/07 07:49:34, Hannes Payer wrote: > ...
5 years, 5 months ago (2015-07-07 11:58:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213313004/80001
5 years, 5 months ago (2015-07-07 12:06:37 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-07 12:30:57 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 12:31:10 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fe8c8c3bc5bdd68e9d57a661f9ac825bdecd5b2b
Cr-Commit-Position: refs/heads/master@{#29515}

Powered by Google App Engine
This is Rietveld 408576698