Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1213303002: PPC: [es6] Make new.target work in functions (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Make new.target work in functions Port 7a63bf77eb7610afdc1a968f7660781e5160ba8d Original commit message: This makes new.target work in [[Call]] and [[Construct]] of ordinary functions. We achieve this by introducing a new construct stub for functions that uses the new.target variable. The construct stub pushes the original constructor just above the receiver in the construct frame. R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/57c5fd7ec5e9c26fc4568e7e16363ec75faa9ec2 Cr-Commit-Position: refs/heads/master@{#29360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -21 lines) Patch
M src/ppc/builtins-ppc.cc View 9 chunks +45 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-06-29 20:49:32 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-06-29 20:58:16 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 5 months ago (2015-06-29 20:58:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213303002/1
5 years, 5 months ago (2015-06-29 20:59:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 21:31:14 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 21:31:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57c5fd7ec5e9c26fc4568e7e16363ec75faa9ec2
Cr-Commit-Position: refs/heads/master@{#29360}

Powered by Google App Engine
This is Rietveld 408576698