Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: utils/tests/pub/lock_file_test.dart

Issue 12133002: add a comment to the generated lock file (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« utils/pub/lock_file.dart ('K') | « utils/pub/lock_file.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/lock_file_test.dart
===================================================================
--- utils/tests/pub/lock_file_test.dart (revision 17925)
+++ utils/tests/pub/lock_file_test.dart (working copy)
@@ -162,8 +162,8 @@
'foo', mockSource, new Version.parse('1.2.3'), 'foo desc');
lockfile.packages['bar'] = new PackageId(
'foo', mockSource, new Version.parse('3.2.1'), 'bar desc');
-
- expect(loadYaml(lockfile.serialize()), equals({
+
+ expect(loadYaml(lockfile.serialize().replaceAll(LockFile.comment, '')), equals({
Bob Nystrom 2013/01/31 22:17:44 This shouldn't be needed. If it is, there's a bug
keertip 2013/01/31 22:23:39 If the comment is not removed, loadYaml fails and
keertip 2013/01/31 22:31:40 Guess that was because the comment should be on a
Bob Nystrom 2013/01/31 22:33:48 That was my hunch too. :)
'packages': {
'foo': {
'version': '1.2.3',
« utils/pub/lock_file.dart ('K') | « utils/pub/lock_file.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698