Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1213283002: Convert aura_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@1_clang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert aura_unittests to run exclusively on Swarming 0 configs already ran on Swarming 19 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert aura_unittests R=sky@chromium.org,dpranke@chromium.org BUG=98637 Committed: https://crrev.com/49f497d7d9c9c6c665abec0ddfbc0df07c3cd6c9 Cr-Commit-Position: refs/heads/master@{#336789}

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : (c) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -6 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A + ui/aura/aura_unittests.isolate View 1 5 chunks +13 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
Marc-Antoine Ruel (Google)
5 years, 5 months ago (2015-06-29 22:56:01 UTC) #3
sky
LGTM https://codereview.chromium.org/1213283002/diff/20001/ui/aura/aura_unittests.isolate File ui/aura/aura_unittests.isolate (right): https://codereview.chromium.org/1213283002/diff/20001/ui/aura/aura_unittests.isolate#newcode1 ui/aura/aura_unittests.isolate:1: # Copyright (c) 2015 The Chromium Authors. All ...
5 years, 5 months ago (2015-06-29 23:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213283002/40001
5 years, 5 months ago (2015-06-30 12:19:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/74914)
5 years, 5 months ago (2015-06-30 12:36:08 UTC) #9
M-A Ruel
On 2015/06/30 12:36:08, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-06-30 13:16:33 UTC) #11
Dirk Pranke
lgtm
5 years, 5 months ago (2015-06-30 15:28:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213283002/40001
5 years, 5 months ago (2015-06-30 15:34:46 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-06-30 15:39:31 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 15:40:21 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49f497d7d9c9c6c665abec0ddfbc0df07c3cd6c9
Cr-Commit-Position: refs/heads/master@{#336789}

Powered by Google App Engine
This is Rietveld 408576698