Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1213243002: win10: Fix various ui glitches (Closed)

Created:
5 years, 5 months ago by scottmg
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

win10: Fix various ui glitches This addresses the most egregious problems so that we look more or less like a reasonable app on Win10. In particular, fixes a too-wide border, removing the rounded corners on the toolbar that don't work when there's no border (see 504044 for agreement from UX), and an ugly overhang in the non-client area in the top-left and top-right of the window. In case you're not familiar with Win10 UI style (I wasn't!) I put a composite of what standard apps plus before/after this patch here http://i.imgur.com/JxNJvBv.png . We aren't easily able to switch to a more "grey"-style title bar at the moment as that's reserved for Windows-store applications (plain Win32 apps like notepad and chrome always get the white title bar style). We might want to look into that in the future as it's pretty harsh, but at least we match the expected system behaviour this way. R=pkasting@chromium.org BUG=504044, 502001 Review URL: https://codereview.chromium.org/1209723004 Cr-Commit-Position: refs/heads/master@{#336438} (cherry picked from commit 48ddea097cd6bd2ef0fc4d133834b55d3b6d99fc) Committed: https://chromium.googlesource.com/chromium/src/+/10234d24f1d8b51dc71feae0f3a977f195ffd1ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -39 lines) Patch
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 5 chunks +47 lines, -36 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scottmg
5 years, 5 months ago (2015-06-29 18:17:53 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10234d24f1d8b51dc71feae0f3a977f195ffd1ac.

Powered by Google App Engine
This is Rietveld 408576698