Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1213233016: Add missing initialization of RawPtr<> local var in r197835. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add missing initialization of RawPtr<> local var in r197835. Only insertCSSOMRuleInMediaRule()'s missing initialization is problematic. Initialize the other occurrences here for consistency, aligning with the convention we try to adhere to (but do not have tool support for catching the failure to do so..) R=pfeldman BUG=178410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/inspector/InspectorStyleSheet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. a bunch of inspector tests are failing on the Oilpan bots, ...
5 years, 5 months ago (2015-07-01 09:48:15 UTC) #2
pfeldman
thanks. lgtm.
5 years, 5 months ago (2015-07-01 09:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213233016/1
5 years, 5 months ago (2015-07-01 09:59:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198128
5 years, 5 months ago (2015-07-01 10:29:39 UTC) #6
haraken
5 years, 5 months ago (2015-07-01 10:31:39 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698