Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: Source/core/dom/Element.cpp

Issue 1213213004: Introduce use counters for shadow DOM handling in plainText() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-07-02T15:13:50 Add comment for |m_handleShadowRoot| Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/DOMSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index f55ea51759ea5c6abe84509bb8d47b5478aaf987..f1e159b23ffbf7324226f8b2a6a64ced6eb9962d 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -2497,7 +2497,7 @@ String Element::innerText()
if (!layoutObject())
return textContent(true);
- return plainText(Position(this, Position::PositionIsBeforeChildren), Position(this, Position::PositionIsAfterChildren));
+ return plainText(Position(this, Position::PositionIsBeforeChildren), Position(this, Position::PositionIsAfterChildren), TextIteratorForInnerText);
yoichio 2015/07/02 06:28:39 Why do't you call UseCounter::count here directly?
yosin_UTC9 2015/07/02 06:40:29 I would like to count only if |plainText()| handle
yoichio 2015/07/02 07:10:32 Can't we check that here?
yosin_UTC9 2015/07/02 08:08:31 Yes, we can. But, we need to traverse tree here. W
}
String Element::outerText()
« no previous file with comments | « no previous file | Source/core/editing/DOMSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698