Issue 1213213003: Port skyx to Dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1213213003: Port skyx to Dart (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Port skyx to Dart Rather than require Sky developers to have a Python environment, we should write our tooling for Sky in Dart. This CL converts skyx.py into skyx.dart and makes skyx.py into a wrapper for skyx.dart. We still need the Python wrapper because gn requires that build actions are written in Python. This code isn't wired into the main build yet. We'll need to add some more pub packages to our buildbot environment first. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/6630fe866772a0ba507199569a7c66aa6ee5a564

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -55 lines)			Patch
M	sky/tools/skyx.py	View	1 2	1 chunk	+14 lines, -56 lines	0 comments	Download
A	sky/tools/skyx/.gitignore	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	sky/tools/skyx/LICENSE	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	sky/tools/skyx/bin/skyx.dart	View	1	1 chunk	+111 lines, -0 lines	0 comments	Download
A	sky/tools/skyx/pubspec.lock	View		1 chunk	+35 lines, -0 lines	0 comments	Download
A	sky/tools/skyx/pubspec.yaml	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-02 16:12:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
6630fe866772a0ba507199569a7c66aa6ee5a564 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1213213003: Port skyx to Dart (Closed)

Description

Patch Set 1 #

Patch Set 2 : works #

Patch Set 3 : fully works #

Patch Set 4 : Make pub publish happy #

Messages