Issue 1213203008: Make it possible to load Sky demos from local bundles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1213203008: Make it possible to load Sky demos from local bundles (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make it possible to load Sky demos from local bundles This CL teaches SkyDemo how to load Sky applications from local bundles. It also teaches home.dart how to request a load from a bundle. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e6e1b72ab68f95a16019a3ba45620bba02107623

Patch Set 1 #

Patch Set 2 : re-upload #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -21 lines)			Patch
M	sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java	View	2 chunks	+18 lines, -6 lines	0 comments	Download
M	sky/sdk/home.dart	View	5 chunks	+15 lines, -4 lines	0 comments	Download
M	sky/services/intents/intents.mojom	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyActivity.java	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyApplication.java	View	3 chunks	+20 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-02 23:43:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e6e1b72ab68f95a16019a3ba45620bba02107623 (presubmit successful).

Expand Messages | Collapse Messages