test/cctest/test-api.cc - Issue 1213203007: Create a internal, global native context used only for generated code stubs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 1213203007: Create a internal, global native context used only for generated code stubs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Review feedback Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index 2bfdeabd42cd606a40e8242d120465dc0414a0ab..3ec4e1b10e38bd04742f7976c742ef61100a6c80 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -11660,7 +11660,8 @@ static int GetGlobalObjectsCount() {

i::HeapIterator it(CcTest::heap());

for (i::HeapObject* object = it.next(); object != NULL; object = it.next())

if (object->IsJSGlobalObject()) count++;

- return count;

+ // Subtract one to compensate for the code stub context that is always present

+ return count - 1;

}

« no previous file with comments | « src/snapshot/serialize.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »