Source/modules/accessibility/AXSpinButton.cpp - Issue 1213203002: Move AXObjectCache::remove so it is after ContainerNode::detach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXSpinButton.cpp

Issue 1213203002: Move AXObjectCache::remove so it is after ContainerNode::detach Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXSpinButton.cpp

diff --git a/Source/modules/accessibility/AXSpinButton.cpp b/Source/modules/accessibility/AXSpinButton.cpp

index e97dc8e14b63103827f7aa355f758eafaa9695bc..22716d61112a76cf43c4c31de8b7741b2cded003 100644

--- a/Source/modules/accessibility/AXSpinButton.cpp

+++ b/Source/modules/accessibility/AXSpinButton.cpp

@@ -80,6 +80,7 @@ AccessibilityRole AXSpinButton::roleValue() const

void AXSpinButton::addChildren()

{

+ ASSERT(!isDetached());

m_haveChildren = true;

AXSpinButtonPart* incrementor = toAXSpinButtonPart(axObjectCache().getOrCreate(SpinButtonPartRole));

« no previous file with comments | « Source/modules/accessibility/AXSlider.cpp ('k') | Source/modules/accessibility/AXTable.cpp » ('j') | no next file with comments »