Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: Source/modules/accessibility/AXScrollView.cpp

Issue 1213203002: Move AXObjectCache::remove so it is after ContainerNode::detach Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXSVGRoot.cpp ('k') | Source/modules/accessibility/AXSlider.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXScrollView.cpp
diff --git a/Source/modules/accessibility/AXScrollView.cpp b/Source/modules/accessibility/AXScrollView.cpp
index abfa02a50399c34cf502ffe65b88ed6a8bcd3e2e..6ded3d29fcfbe8acc5b973aba8da269a7ff394f2 100644
--- a/Source/modules/accessibility/AXScrollView.cpp
+++ b/Source/modules/accessibility/AXScrollView.cpp
@@ -171,6 +171,7 @@ bool AXScrollView::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReasons)
void AXScrollView::addChildren()
{
+ ASSERT(!isDetached());
ASSERT(!m_haveChildren);
m_haveChildren = true;
@@ -225,6 +226,7 @@ FrameView* AXScrollView::documentFrameView() const
AXObject* AXScrollView::computeParent() const
{
+ ASSERT(!isDetached());
if (!m_scrollView || !m_scrollView->isFrameView())
return 0;
« no previous file with comments | « Source/modules/accessibility/AXSVGRoot.cpp ('k') | Source/modules/accessibility/AXSlider.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698