ui/aura/window.cc - Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/window.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/window.cc

diff --git a/ui/aura/window.cc b/ui/aura/window.cc

index 1e293b72343b994b81641e0f7570d74d2105ce0c..7fd54d1671097e84b9c24fb3978de2dffe9a26be 100644

--- a/ui/aura/window.cc

+++ b/ui/aura/window.cc

@@ -328,7 +328,7 @@ void Window::Show() {

// It is not allowed that a window is visible but the layers alpha is fully

// transparent since the window would still be considered to be active but

// could not be seen.

- DCHECK_IMPLIES(visible_, layer()->GetTargetOpacity() > 0.0f);

+ DCHECK(!visible_ || layer()->GetTargetOpacity() > 0.0f);

SetVisible(true);

}

« no previous file with comments | « gpu/command_buffer/service/texture_definition.cc ('k') | ui/base/resource/data_pack.cc » ('j') | no next file with comments »