base/trace_event/trace_event_impl.cc - Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_impl.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_impl.cc

diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc

index 1fc22565d0ec182e1e908abb40f36921846f23bb..62ba6632523b91edd4f04e6efea92fb30fcb25c0 100644

--- a/base/trace_event/trace_event_impl.cc

+++ b/base/trace_event/trace_event_impl.cc

@@ -1805,7 +1805,7 @@ void TraceLog::FlushInternal(const TraceLog::OutputCallback& cb,

flush_task_runner_ = ThreadTaskRunnerHandle::IsSet()

? ThreadTaskRunnerHandle::Get()

: nullptr;

- DCHECK_IMPLIES(thread_message_loops_.size(), flush_task_runner_);

+ DCHECK(thread_message_loops_.empty() || flush_task_runner_);

flush_output_callback_ = cb;

if (thread_shared_chunk_) {