Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/browsing_data/browsing_data_helper.h" 9 #include "chrome/browser/browsing_data/browsing_data_helper.h"
10 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 10 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 timer_.reset(new base::ElapsedTimer); 101 timer_.reset(new base::ElapsedTimer);
102 base::AutoReset<bool> resetter(&should_pop_up_bubble_, true); 102 base::AutoReset<bool> resetter(&should_pop_up_bubble_, true);
103 UpdateBubbleAndIconVisibility(); 103 UpdateBubbleAndIconVisibility();
104 } 104 }
105 105
106 bool ManagePasswordsUIController::OnChooseCredentials( 106 bool ManagePasswordsUIController::OnChooseCredentials(
107 ScopedVector<autofill::PasswordForm> local_credentials, 107 ScopedVector<autofill::PasswordForm> local_credentials,
108 ScopedVector<autofill::PasswordForm> federated_credentials, 108 ScopedVector<autofill::PasswordForm> federated_credentials,
109 const GURL& origin, 109 const GURL& origin,
110 base::Callback<void(const password_manager::CredentialInfo&)> callback) { 110 base::Callback<void(const password_manager::CredentialInfo&)> callback) {
111 DCHECK_IMPLIES(local_credentials.empty(), !federated_credentials.empty()); 111 DCHECK(!local_credentials.empty() || !federated_credentials.empty());
112 passwords_data_.OnRequestCredentials(local_credentials.Pass(), 112 passwords_data_.OnRequestCredentials(local_credentials.Pass(),
113 federated_credentials.Pass(), 113 federated_credentials.Pass(),
114 origin); 114 origin);
115 base::AutoReset<bool> resetter(&should_pop_up_bubble_, true); 115 base::AutoReset<bool> resetter(&should_pop_up_bubble_, true);
116 #if defined(OS_ANDROID) 116 #if defined(OS_ANDROID)
117 UpdateAndroidAccountChooserInfoBarVisibility(); 117 UpdateAndroidAccountChooserInfoBarVisibility();
118 #else 118 #else
119 UpdateBubbleAndIconVisibility(); 119 UpdateBubbleAndIconVisibility();
120 #endif 120 #endif
121 if (!should_pop_up_bubble_) { 121 if (!should_pop_up_bubble_) {
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE); 364 updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE);
365 #endif 365 #endif
366 } 366 }
367 367
368 void ManagePasswordsUIController::WebContentsDestroyed() { 368 void ManagePasswordsUIController::WebContentsDestroyed() {
369 password_manager::PasswordStore* password_store = 369 password_manager::PasswordStore* password_store =
370 GetPasswordStore(web_contents()); 370 GetPasswordStore(web_contents());
371 if (password_store) 371 if (password_store)
372 password_store->RemoveObserver(this); 372 password_store->RemoveObserver(this);
373 } 373 }
OLDNEW
« no previous file with comments | « cc/trees/property_tree_builder.cc ('k') | content/browser/android/in_process/synchronous_compositor_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698