Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1213183003: [turbofan] Fix exit control flow in TryCatchBuilder. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix exit control flow in TryCatchBuilder. This makes sure that the exit control flow that merges the try-block with the catch-block after a try-catch-statement creates a new merge node in cases where it has to. Otherwise dangling phi nodes might have the wrong number of value inputs. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-505354 BUG=chromium:505354 LOG=N Committed: https://crrev.com/df06f1c71511ea7f60d0117111e3ee5346d47d83 Cr-Commit-Position: refs/heads/master@{#29362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/compiler/control-builders.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-505354.js View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-06-29 17:13:15 UTC) #1
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-06-30 03:00:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213183003/1
5 years, 5 months ago (2015-06-30 03:00:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 03:23:35 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 03:23:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df06f1c71511ea7f60d0117111e3ee5346d47d83
Cr-Commit-Position: refs/heads/master@{#29362}

Powered by Google App Engine
This is Rietveld 408576698