Cope with intrinsic height styled on table cells

Source/core/layout/LayoutTableCell.h

Index: Source/core/layout/LayoutTableCell.h
diff --git a/Source/core/layout/LayoutTableCell.h b/Source/core/layout/LayoutTableCell.h
index 456cb3f6f5fefb0786bd8f132659c7fc852152cd..d682e6f27dd671e6316e610b320525b5593279cf 100644
--- a/Source/core/layout/LayoutTableCell.h
+++ b/Source/core/layout/LayoutTableCell.h
@@ -100,9 +100,11 @@ public:
         return styleWidth;
     }
 
-    int logicalHeightFromStyle() const
+    LayoutUnit logicalHeightFromStyle() const

[mstensho (USE GERRIT), 2015/07/12 19:38:55]

Why change the return type here? The table code seems to be in love with ints,
so I see no reason not to be consistent. Did you do this because of my remark
about using "LayoutUnit()" instead of "0"? Or was it to avoid an explicit
"toInt()" on the result from valueForLength(), to give the last two ternary
operands the same type?

[rhogan, 2015/07/13 18:28:21]

One of the two callers, LayoutTableCell::cellBaselinePosition,  uses it as a
LayoutUnit so my intention is to save the unnecessary cast in that case, and
defer it in the other.

I'm assuming that max(logicalHeightFromStyle() - computedCSSPaddingAfter() -
borderAfter(), borderBefore() + paddingBefore()) knows the two callers are
LayoutUnits but maybe they need to be max<LayoutUnit>()?

[mstensho (USE GERRIT), 2015/07/14 08:45:29]

I don't know how that type soup is resolved, but how about changing it back to
int for now, since changing to LayoutUnit isn't relevant for your fix, and since
most other parts of the table code use ints?

     {
-        int styleLogicalHeight = valueForLength(style()->logicalHeight(), 0);
+        Length height = style()->logicalHeight();
+        LayoutUnit styleLogicalHeight = height.isIntrinsic() ? LayoutUnit() : valueForLength(height, LayoutUnit());
+
         // In strict mode, box-sizing: content-box do the right thing and actually add in the border and padding.
         // Call computedCSSPadding* directly to avoid including implicitPadding.
         if (!document().inQuirksMode() && style()->boxSizing() != BORDER_BOX)