Cope with intrinsic height styled on table cells

Source/core/layout/LayoutTableCell.h

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2013 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 82 matching lines @@
     Length styleOrColLogicalWidth() const
     {
         Length styleWidth = style()->logicalWidth();
         if (!styleWidth.isAuto())
             return styleWidth;
         if (LayoutTableCol* firstColumn = table()->colElement(col()))
             return logicalWidthFromColumns(firstColumn, styleWidth);
         return styleWidth;
     }
 
+    int computeLogicalHeightFromCellStyle(const Length& height) const
+    {
+        if (height.isIntrinsic())
+            return computeIntrinsicLogicalContentHeightUsing(height, logicalHeight() - borderAndPaddingLogicalHeight(), borderAndPaddingLogicalHeight());
+        return valueForLength(height, 0);
+    }
+
     int logicalHeightFromStyle() const
     {
-        int styleLogicalHeight = valueForLength(style()->logicalHeight(), 0);
+        int styleLogicalHeight = computeLogicalHeightFromCellStyle(style()->logicalHeight());

[mstensho (USE GERRIT), 2015/07/07 07:11:39]

Any reason why we shouldn't just treat intrinsic values as auto? I know
intrinsic and auto isn't the same, but I don't see any point in treating them
differently inside tables. There's no table spec that defines how to treat
intrinsic height values, as far as I know. Tables and fancy height property
values are two technologies that never met, very much like 5.25" floppy drives
and USB ports.

[rhogan, 2015/07/07 18:40:02]

Sure, but we treat them this way when they're set on the table itself, see
LayoutTable::convertStyleLogicalHeightToComputedHeight() and co. So at least
we're being internally consistent this way. :)

         // In strict mode, box-sizing: content-box do the right thing and actually add in the border and padding.
         // Call computedCSSPadding* directly to avoid including implicitPadding.
         if (!document().inQuirksMode() && style()->boxSizing() != BORDER_BOX)
             styleLogicalHeight += (computedCSSPaddingBefore() + computedCSSPaddingAfter()).floor() + borderBefore() + borderAfter();
         return styleLogicalHeight;
     }
 
     int logicalHeightForRowSizing() const
     {
         // FIXME: This function does too much work, and is very hot during table layout!
@@ skipping 193 matching lines @@
 
 inline LayoutTableCell* LayoutTableRow::lastCell() const
 {
     ASSERT(children() == virtualChildren());
     return toLayoutTableCell(children()->lastChild());
 }
 
 } // namespace blink
 
 #endif // LayoutTableCell_h