Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1213133004: Add the 'Ask Google' option to the spelling submenu on Mac. (Closed)

Created:
5 years, 5 months ago by Julius
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the 'Ask Google' option to the spelling submenu on Mac. For some reason the "Ask Google" option does not appear in the right- click menu on Mac, even though it's present in the Settings menu. BUG=5102 Committed: https://crrev.com/8657b1d9e7c2040de20632fdf2ede3765cec4d9c Cr-Commit-Position: refs/heads/master@{#336790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Julius
lazyboy, PTAL at Patch Set #1
5 years, 5 months ago (2015-06-29 23:29:16 UTC) #2
lazyboy
lgtm Please update the bug # to a valid bug number in crbug.com/, 5201 seems ...
5 years, 5 months ago (2015-06-30 05:35:14 UTC) #3
please use gerrit instead
The bug number should be 5102. I'll update it for you. Please click on your ...
5 years, 5 months ago (2015-06-30 15:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213133004/1
5 years, 5 months ago (2015-06-30 15:35:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 15:40:35 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8657b1d9e7c2040de20632fdf2ede3765cec4d9c Cr-Commit-Position: refs/heads/master@{#336790}
5 years, 5 months ago (2015-06-30 15:41:51 UTC) #8
groby-ooo-7-16
On 2015/06/30 15:41:51, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 4 months ago (2015-07-31 21:33:17 UTC) #9
please use gerrit instead
On 2015/07/31 21:33:17, groby wrote: > On 2015/06/30 15:41:51, commit-bot: I haz the power wrote: ...
5 years, 4 months ago (2015-07-31 21:53:51 UTC) #10
please use gerrit instead
5 years, 4 months ago (2015-08-03 19:53:39 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1264583003/ by rouslan@chromium.org.

The reason for reverting is: Reverting after discussion with Rachel..

Powered by Google App Engine
This is Rietveld 408576698