Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: src/objects.cc

Issue 1213123003: Version 4.3.61.33 (cherry-pick) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@4.3
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8-version.h ('k') | src/objects-printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 77e79160d6c2032d5798fae75cf40e5f699e1c5a..fdb1741ce7b8083c17cd23ecaf1fb5f8a3b52697 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2639,6 +2639,9 @@ Handle<Map> Map::ReconfigureProperty(Handle<Map> old_map, int modify_index,
target_descriptors->GetFieldType(modify_index)));
}
#endif
+ if (*target_map != *old_map) {
+ old_map->NotifyLeafMapLayoutChange();
+ }
return target_map;
}
@@ -2892,13 +2895,6 @@ Handle<Map> Map::ReconfigureProperty(Handle<Map> old_map, int modify_index,
split_kind, old_descriptors->GetKey(split_nof), split_attributes,
*new_descriptors, *new_layout_descriptor);
- if (from_kind != to_kind) {
- // There was an elements kind change in the middle of transition tree and
- // we reconstructed the tree so that all elements kind transitions are
- // done at the beginning, therefore the |old_map| is no longer stable.
- old_map->NotifyLeafMapLayoutChange();
- }
-
// If |transition_target_deprecated| is true then the transition array
// already contains entry for given descriptor. This means that the transition
// could be inserted regardless of whether transitions array is full or not.
@@ -2909,6 +2905,8 @@ Handle<Map> Map::ReconfigureProperty(Handle<Map> old_map, int modify_index,
"GenAll_CantHaveMoreTransitions");
}
+ old_map->NotifyLeafMapLayoutChange();
+
if (FLAG_trace_generalization && modify_index >= 0) {
PropertyDetails old_details = old_descriptors->GetDetails(modify_index);
PropertyDetails new_details = new_descriptors->GetDetails(modify_index);
« no previous file with comments | « include/v8-version.h ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698