Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1213113007: Prepare profiler test for try-catch being optimizable. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
Yang, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Prepare profiler test for try-catch being optimizable. This is an adaptation of test-profile-generator/BailoutReason to when try-catch statements are optimizable. They will no longer cause any bailout reason to be reported. R=yangguo@chromium.org TEST=cctest/test-profile-generator/BailoutReason Committed: https://crrev.com/aaf56d601acfd8dcf47c744ce52bf5e765d23bae Cr-Commit-Position: refs/heads/master@{#29440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M test/cctest/test-profile-generator.cc View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-01 13:38:14 UTC) #1
Michael Starzinger
Please advise if there are any folks from the DevTools side that we should notify ...
5 years, 5 months ago (2015-07-01 13:38:59 UTC) #2
Yang
On 2015/07/01 13:38:59, Michael Starzinger wrote: > Please advise if there are any folks from ...
5 years, 5 months ago (2015-07-02 08:25:09 UTC) #3
Yang
5 years, 5 months ago (2015-07-02 08:25:31 UTC) #5
yurys
LGTM. Thanks for keeping us posted and good to hear that try-catch are going to ...
5 years, 5 months ago (2015-07-02 08:51:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213113007/1
5 years, 5 months ago (2015-07-02 09:21:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 09:22:53 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 09:23:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaf56d601acfd8dcf47c744ce52bf5e765d23bae
Cr-Commit-Position: refs/heads/master@{#29440}

Powered by Google App Engine
This is Rietveld 408576698