Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1213113006: Revert of Refactor OS X sandbox processing and audit sandbox files (Closed)

Created:
5 years, 5 months ago by caseq
Modified:
5 years, 5 months ago
Reviewers:
Robert Sesek, Greg K
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor OS X sandbox processing and audit sandbox files (patchset #6 id:120001 of https://codereview.chromium.org/1186233004/) Reason for revert: Speculative revert to see if this could be a possible reason for MacOS 10.6 layout test bot failures starting since http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/41745 Original issue's description: > Refactor OS X sandbox processing and audit sandbox files > > Audited the sandbox files to enusre all rules are necessary and removed > any incorrect comments. > > The OS X Sandbox code is refactored to get rid of all string processing > of the raw scheme code in the sandbox profiles. By using the ability to > pass parameters into sandbox profiles, the variable substitution logic > is performed by the scheme interpreter itself. > > BUG=242704 > > Committed: https://crrev.com/76eaa8778a322803dc3ac20cda05525e615dec4d > Cr-Commit-Position: refs/heads/master@{#336610} TBR=rsesek@chromium.org,kerrnel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=242704 Committed: https://crrev.com/44db59b0c50e3e3b1af905d5761374f1d5175133 Cr-Commit-Position: refs/heads/master@{#336757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -362 lines) Patch
M content/browser/gpu.sb View 1 chunk +10 lines, -11 lines 0 comments Download
M content/common/common.sb View 2 chunks +14 lines, -26 lines 0 comments Download
M content/common/sandbox_mac.h View 4 chunks +73 lines, -28 lines 0 comments Download
M content/common/sandbox_mac.mm View 7 chunks +193 lines, -97 lines 0 comments Download
D content/common/sandbox_mac_compiler_unittest.mm View 1 chunk +0 lines, -160 lines 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 1 chunk +32 lines, -24 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi.sb View 1 chunk +6 lines, -4 lines 0 comments Download
M content/renderer/renderer.sb View 1 chunk +8 lines, -6 lines 0 comments Download
M content/utility/utility.sb View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
caseq
Created Revert of Refactor OS X sandbox processing and audit sandbox files
5 years, 5 months ago (2015-06-30 10:25:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213113006/1
5 years, 5 months ago (2015-06-30 10:26:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 10:26:59 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 10:27:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44db59b0c50e3e3b1af905d5761374f1d5175133
Cr-Commit-Position: refs/heads/master@{#336757}

Powered by Google App Engine
This is Rietveld 408576698