Chromium Code Reviews
DescriptionImprove the diagnostics for include order presubmit checks
The information given by the presubmit checks when an include error
violation is found is not always the clearest, especially to a new
Chrome developer. The rules for determining which group a header file
goes into are not immediately obvious and the warnings don't say whether
the problem is a sort order or a group order. This change adds that
information. It also puts the URL on a separate line for easier
selection, especially important on Windows.
The old output looks like this:
** Presubmit Messages **
Your #include order seems to be broken. Remember to use the right collation (LC_COLLATE=C) and check https://google-styleguide.googlecode.com
m/svn/trunk/cppguide.html#Names_and_Order_of_Includes
chrome\browser\task_manager\task_manager.cc:10 \
chrome\browser\task_manager\task_manager.cc:11
The new output looks like this:
** Presubmit Messages **
Your #include order seems to be broken. Remember to use the right collation (LC_COLLATE=C) and check
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes
chrome\browser\task_manager\task_manager.cc:10: - c++ system include file in wrong block \
chrome\browser\task_manager\task_manager.cc:11: - line belongs before previous line
Notice the explanations for why a line is highlighted, and the
non-wordwrapped URL.
R=maruel@chromium.org
Committed: https://crrev.com/70fadb041abae3242d2c00066ff806f47a98aecc
Cr-Commit-Position: refs/heads/master@{#336813}
Patch Set 1 #
Messages
Total messages: 9 (2 generated)
|
|||||||||||||||||||