Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1213063011: Don't cap num_cores at 32 on 32-bit Windows. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't cap num_cores at 32 on 32-bit Windows. See here for a similar change in Ninja. Wanna bet they just got Z840s too? https://github.com/martine/ninja/commit/8c8834acffdc0da0d94119725929acc712c9dfad BUG=skia: Committed: https://skia.googlesource.com/skia/+/a760942b3579f7d863345b9d083abdc187266e08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkTaskGroup.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
5 years, 5 months ago (2015-07-01 19:44:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213063011/1
5 years, 5 months ago (2015-07-01 19:45:02 UTC) #4
caryclark
lgtm
5 years, 5 months ago (2015-07-01 19:55:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213063011/1
5 years, 5 months ago (2015-07-01 19:58:33 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 20:06:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a760942b3579f7d863345b9d083abdc187266e08

Powered by Google App Engine
This is Rietveld 408576698