Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1213043005: [turbofan] Use OSR value for innermost context value. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use OSR value for innermost context value. This changes the OsrValue insertion in the AstGraphBuilder to emit a proper OsrValue instead of a special Parameter for the inner context value at the OSR entry point. R=titzer@chromium.org Committed: https://crrev.com/21d330c89610d1ecd1419566f5cfcce1d7eee5fa Cr-Commit-Position: refs/heads/master@{#29471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Ben: PTAL. Benedikt: FYI.
5 years, 5 months ago (2015-07-03 13:13:30 UTC) #2
titzer
lgtm
5 years, 5 months ago (2015-07-03 16:43:20 UTC) #3
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-07-06 03:11:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213043005/1
5 years, 5 months ago (2015-07-06 03:11:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 03:39:20 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 03:39:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21d330c89610d1ecd1419566f5cfcce1d7eee5fa
Cr-Commit-Position: refs/heads/master@{#29471}

Powered by Google App Engine
This is Rietveld 408576698