Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/password_manager/simple_password_store_mac.cc

Issue 1213043003: Start the migration of passwords from the Keychain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added a comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/simple_password_store_mac.cc
diff --git a/chrome/browser/password_manager/simple_password_store_mac.cc b/chrome/browser/password_manager/simple_password_store_mac.cc
index 6c60f984a67d9fff7ad5fd6a79a2f1bad79c09cf..a16673d984a13d5c88867804d5feebbf438a443f 100644
--- a/chrome/browser/password_manager/simple_password_store_mac.cc
+++ b/chrome/browser/password_manager/simple_password_store_mac.cc
@@ -10,18 +10,25 @@ SimplePasswordStoreMac::SimplePasswordStoreMac(
scoped_ptr<password_manager::LoginDatabase> login_db)
: PasswordStoreDefault(main_thread_runner, background_thread_runner,
login_db.Pass()) {
- this->login_db()->set_clear_password_values(false);
+ if (this->login_db())
+ this->login_db()->set_clear_password_values(false);
}
SimplePasswordStoreMac::~SimplePasswordStoreMac() {
}
-bool SimplePasswordStoreMac::Init(
- const syncer::SyncableService::StartSyncFlare& flare) {
- // All the initialization has to be done by the owner of the object.
- return true;
+void SimplePasswordStoreMac::InitWithTaskRunner(
+ scoped_refptr<base::SingleThreadTaskRunner> background_task_runner,
+ scoped_ptr<password_manager::LoginDatabase> login_db) {
+ db_thread_runner_ = background_task_runner;
+ DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());
+ set_login_db(login_db.Pass());
+ if (this->login_db())
+ this->login_db()->set_clear_password_values(false);
}
-void SimplePasswordStoreMac::Shutdown() {
- PasswordStoreDefault::Shutdown();
+bool SimplePasswordStoreMac::Init(
+ const syncer::SyncableService::StartSyncFlare& flare) {
+ NOTREACHED();
+ return false;
}

Powered by Google App Engine
This is Rietveld 408576698