Start the migration of passwords from the Keychain.

components/password_manager/core/browser/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_manager.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
@@ skipping 124 matching lines @@
 void PasswordManager::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(
       prefs::kPasswordManagerSavingEnabled,
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterBooleanPref(prefs::kPasswordManagerAutoSignin, true);
   registry->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords,
                                 true);
   registry->RegisterListPref(prefs::kPasswordManagerGroupsForDomains);
+#if defined(OS_MACOSX)
+  registry->RegisterIntegerPref(prefs::kKeychainMigrationStatus, 0);

[vabr (Chromium), 2015/07/03 08:40:48]

While not detectable to the compiler, this is a kind of dependency violation --
the 0 here means the proxy's NOT_STARTED constant, which is defined in //chrome
and "used" here in //components.

There are multiple ways to address this, out of which I find the following the
easiest and sufficiently clean:

Move the definition of MigrationStatus to
components/password_manager/core/common/password_manager_pref_names.h. The pref
name is already there, so it makes sense to define the pref's values in the same
place. Then you can refer NOT_STARTED here directly, and there will be no
dependency violation.

[vasilii, 2015/07/03 12:59:11]

Done.

+#endif
 }
 
 #if defined(OS_WIN)
 // static
 void PasswordManager::RegisterLocalPrefs(PrefRegistrySimple* registry) {
   registry->RegisterInt64Pref(prefs::kOsPasswordLastChanged, 0);
   registry->RegisterBooleanPref(prefs::kOsPasswordBlank, false);
 }
 #endif
 
@@ skipping 602 matching lines @@
       if (ServerTypeToPrediction((*field)->server_type(), &prediction_type))
         predictions[form->ToFormData()][prediction_type] = *(*field);
     }
   }
   if (predictions.empty())
     return;
   driver->AutofillDataReceived(predictions);
 }
 
 }  // namespace password_manager