Start the migration of passwords from the Keychain.

chrome/browser/password_manager/simple_password_store_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_SIMPLE_PASSWORD_STORE_MAC_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_SIMPLE_PASSWORD_STORE_MAC_H_
 
 #include "components/password_manager/core/browser/password_store_default.h"
 
 // The same as PasswordStoreDefault but running on the dedicated thread. The
 // owner is responsible for the thread lifetime.
 class SimplePasswordStoreMac : public password_manager::PasswordStoreDefault {
  public:
   SimplePasswordStoreMac(
       scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,
       scoped_refptr<base::SingleThreadTaskRunner> background_thread_runner,

[vabr (Chromium), 2015/07/03 08:40:48]

nit: Passing of background runners both in the constructor and in
InitWithTaskRunner deserves an explanation in a comment. Alternatively, if it
always passes nullptr to PasswordStoreDefault, then we should drop it as the
argument and just hard-code nullptr to the call to PasswordStoreDefault's
constructor.

[vasilii, 2015/07/03 12:59:11]

Done. I use both null and non-null calls.

       scoped_ptr<password_manager::LoginDatabase> login_db);
 
-  // Just hides the parent method. All the initialization is to be done by
-  // PasswordStoreProxyMac that is an owner of the class.
-  bool Init(const syncer::SyncableService::StartSyncFlare& flare) override;
+  // Sets the background thread and LoginDatabase. |login_db| should be already
+  // inited.
+  void InitWithTaskRunner(
+      scoped_refptr<base::SingleThreadTaskRunner> background_task_runner,
+      scoped_ptr<password_manager::LoginDatabase> login_db);
 
   // Clean |background_thread_runner_|.
   void Shutdown() override;
 
   using PasswordStoreDefault::GetBackgroundTaskRunner;
 
  protected:
   ~SimplePasswordStoreMac() override;
 
  private:
+  using PasswordStoreDefault::Init;

[vabr (Chromium), 2015/07/03 08:40:48]

Please remind me: where is this called from?

[vasilii, 2015/07/03 12:59:11]

It's not called, that's why it's private.

[vabr (Chromium), 2015/07/06 09:50:19]

Fair enough. But if you want to avoid people calling Init on
SimplePasswordStoreMac by accident, I would suggest actually providing an
implementation and putting NOTREACHED() in it. This way one can still call
Init() through down-casting the store's pointer. The private + using hint may be
too subtle and get missed, whereas a NOTREACHED() is a clear statement.

[vasilii, 2015/07/06 13:57:57]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(SimplePasswordStoreMac);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_SIMPLE_PASSWORD_STORE_MAC_H_