Issue 1213043002: Make TabBar conform to the Material spec for icon/text tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1213043002: Make TabBar conform to the Material spec for icon/text tabs (Closed)

Created:
5 years, 6 months ago by hansmuller1

Modified:
5 years, 6 months ago

Reviewers:
hansmuller, Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make TabBar conform to the Material spec for icon/text tabs When both icons and text are specified, the icon goes on top, 10 pixels of margin goes in between, and the TabBar's height grows to 72. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2ed6f278be5a60c37fd8d1b23912ee16a60f067f

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -19 lines)			Patch
	M	sky/sdk/lib/widgets/tabs.dart	View		9 chunks	+34 lines, -8 lines	0 comments	Download
	M	sky/tests/examples/tabs-expected.txt	View	1	4 chunks	+19 lines, -11 lines	0 comments	Download

Total messages: 5 (2 generated)

hansmuller1

5 years, 6 months ago (2015-06-26 23:16:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2ed6f278be5a60c37fd8d1b23912ee16a60f067f (presubmit successful).