Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1213033003: Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. The ~ means "don't run this". This keeps all the other bots running the code, skipping it only on the whiny TSAN bot. BUG=skia:3997 Committed: https://skia.googlesource.com/skia/+/37cc0b2e31e4a078b12790253d7032d36271440c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/dm_flags.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dm_flags.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 5 months ago (2015-06-30 17:44:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213033003/1
5 years, 5 months ago (2015-06-30 17:44:23 UTC) #4
herb_g
lgtm
5 years, 5 months ago (2015-06-30 17:50:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213033003/1
5 years, 5 months ago (2015-06-30 17:51:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/37cc0b2e31e4a078b12790253d7032d36271440c
5 years, 5 months ago (2015-06-30 17:51:54 UTC) #9
herb_g
5 years, 5 months ago (2015-06-30 21:23:07 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1218153004/ by herb@google.com.

The reason for reverting is: Add tsan annotations to repair tests..

Powered by Google App Engine
This is Rietveld 408576698