Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 1213033002: Fix runtimeType.toString for tear-offs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
index 1cea1f35828bdfd5bcdf709d34ca9219ce664739..1c75d1b6c75bbdcf16ea2c44c63983859a896906 100644
--- a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
@@ -133,8 +133,6 @@ class Emitter implements emitterTask.Emitter {
@override
js.Template templateForBuiltin(JsBuiltin builtin) {
- String typeNameProperty = ModelEmitter.typeNameProperty;
-
switch (builtin) {
case JsBuiltin.dartObjectConstructor:
return js.js.expressionTemplateYielding(
@@ -148,7 +146,7 @@ class Emitter implements emitterTask.Emitter {
return _backend.rti.representationGenerator.templateForIsFunctionType;
case JsBuiltin.rawRtiToJsConstructorName:
- return js.js.expressionTemplateFor("#.$typeNameProperty");
+ return js.js.expressionTemplateFor("#.name");
case JsBuiltin.rawRuntimeType:
return js.js.expressionTemplateFor("#.constructor");
@@ -167,19 +165,19 @@ class Emitter implements emitterTask.Emitter {
String functionClassName =
_backend.namer.runtimeTypeName(_compiler.functionClass);
return js.js.expressionTemplateFor(
- '#.$typeNameProperty === "$functionClassName"');
+ '#.name === "$functionClassName"');
case JsBuiltin.isNullTypeRti:
String nullClassName =
_backend.namer.runtimeTypeName(_compiler.nullClass);
return js.js.expressionTemplateFor(
- '#.$typeNameProperty === "$nullClassName"');
+ '#.name === "$nullClassName"');
case JsBuiltin.isDartObjectTypeRti:
String dartObjectClassName =
_backend.namer.runtimeTypeName(_compiler.objectClass);
return js.js.expressionTemplateFor(
- '#.$typeNameProperty === "$dartObjectClassName"');
+ '#.name === "$dartObjectClassName"');
case JsBuiltin.getMetadata:
return _emitter.templateForReadMetadata;

Powered by Google App Engine
This is Rietveld 408576698