Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213013003: Revert of Rework GrPipelineInfo (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Rework GrPipelineInfo (patchset #7 id:120001 of https://codereview.chromium.org/1213383005/) Reason for revert: breaking stuff! Original issue's description: > Makes GrPipelineInfo a class with query functions used by GrBatch subclasses. > > Committed: https://skia.googlesource.com/skia/+/f5179a4c490bc787190321bd8ffdb0e6a4efa9ac TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d07a2793baea42956d27b3ad47ed562f08e4570a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -256 lines) Patch
M include/gpu/GrXferProcessor.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 2 chunks +18 lines, -15 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 11 chunks +21 lines, -23 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +14 lines, -12 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 5 chunks +35 lines, -30 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 3 chunks +8 lines, -25 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 chunk +9 lines, -58 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Rework GrPipelineInfo
5 years, 5 months ago (2015-07-08 17:20:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213013003/1
5 years, 5 months ago (2015-07-08 17:20:09 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 17:20:23 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d07a2793baea42956d27b3ad47ed562f08e4570a

Powered by Google App Engine
This is Rietveld 408576698